Switch to PNPM Workspace #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
February 26, 2024 15:56
convert jsx to tsx /nimprove types/nmodify compose file for production /nadd esbuild config for client-entry bundling /nimprove tsconfigs /n update deps
… and isServer functions
J3m5
changed the title
dunglas
approved these changes
Mar 18, 2024
|
Could you also re-add the Next.js example to the official Next.js repository? This gives more visibility to the project. |
|
Feel free to merge when CS will be fixed @J3m5! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request transitions our project's package manager from yarn to pnpm, configuring it to operate as a workspace. This change brings several improvements to our workflow and project structure:
Enhanced Dependency Management: By leveraging pnpm workspaces, we can now more efficiently manage dependencies across multiple packages. This setup allows us to include the
react-esibuild as a seamlessly integrated dependency for our examples.Dependency Updates and Refactoring: The transition includes a thorough update of our project dependencies to their latest versions.
Configuration Enhancements: Improvements have been made to our project's configuration settings.
Examples Updated: All examples have been updated to reflect the latest versions of React and Next.js.
Better compatibility: The WithESI component have been enhanced for improved compatibility in different environments. This includes more accurate detection mechanisms for client/server/bundler scenarios.
Production ready Dockerfile: I added a production-ready Dockerfile to our examples. This allows us to test the react-esi implementation in a production environment, ensuring that our changes do not impact production builds.