add ext-ldap and ext-sysvsem to static builder, add PHP_EXTENSION_LIBS to enhance extensions #203
Conversation
DubbleClick
changed the title
|
it is possible that the default selection for --with-libs will not compile at the moment, because |
DubbleClick
changed the title
…h as libjpeg for gd)
|
this should work in combination with #241 once the spc imap branch is merged |
|
drafted until linux c++ extension support is merged in static-php |
|
Might have to rerun the failed checks, they should work on spc master now. |
| @@ -57,7 +58,7 @@ RUN git clone --depth=1 https://github.com/crazywhalecc/static-php-cli . && \ | |||
|
|
|||
| RUN --mount=type=secret,id=github-token GITHUB_TOKEN=$(cat /run/secrets/github-token) ./bin/spc download --with-php=$PHP_VERSION --all | |||
|
|
|||
| RUN ./bin/spc build --build-embed --enable-zts "$PHP_EXTENSIONS" | |||
| RUN ./bin/spc build --build-embed --enable-zts --disable-opcache-jit "$PHP_EXTENSIONS" --with-libs="$PHP_EXTENSION_LIBS" | |||
There was a problem hiding this comment.
Is it mandatory to disable the JIT?
There was a problem hiding this comment.
Not necessarily, I haven't figured out what causes the relocation problems, but compiling FrankenPHP as non-PIE fixes the issue and JIT doesn't have to be disabled.
Your initial implementation in spc disabled it generally, I just made it enabled by default so that when someone doesn't build position independent executables it may be used. Producing static pic php leads to issues on other places too, see php/php-src#12442 (strangely not the case with alpine gcc, which has default-pie enabled).
There was a problem hiding this comment.
Ok. I'm not sure of what's the best to do. Let's merge as is for now. Thank you very much for all your work on these topics!
There was a problem hiding this comment.
Unfortunately I can't really figure out what causes or fixes these issues and google isn't of much help either. All the suggestions (such as upgrading bintools) don't appear to make a difference.
-snip-
closes #256