perf: Remove all Cgo handles #1071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frankenphp.go # go.mod # worker.go
…orker file itself.
Co-authored-by: Kévin Dunglas <[email protected]>
…kenphp into file-watchers # Conflicts: # Dockerfile
added 28 commits
September 29, 2024 13:07
…the {bracket} pattern.
# Conflicts: # frankenphp.go
# Conflicts: # worker.go
# Conflicts: # frankenphp.c # worker.go
# Conflicts: # worker.go
# Conflicts: # .github/workflows/sanitizers.yaml # .github/workflows/tests.yaml # build-static.sh # dev-alpine.Dockerfile # dev.Dockerfile # frankenphp.go # static-builder.Dockerfile # worker.go
|
I'll reopen this pull request from a different branch, seems like 'main' didn't merge correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve handle performance as discussed in #934
Instead of optimizing handles, they are completely removed and replaced by passing the index of the current thread
This makes it so we can store a slice of phpThreads on the go side and have more potential control over thread
creation/destruction/metrics.
The performance impacts are similar to #934.
A quick worker benchmark:
wrk -t 4 -c 150 -d 60 http://localhost:8124on WSL bookworm-Docker 20 CPU cores 40 threadsNote that this benchmark was done with php_import_environment_variables disabled (I plan to address it in a separate PR).
This PR comes with some necessary refactoring (especially in
worker.go) so I hope it doesn't conflict too much with other potential PRs.