Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This doesn't work anymore #4

Open
akeelnazir opened this issue May 27, 2020 · 4 comments
Open

This doesn't work anymore #4

akeelnazir opened this issue May 27, 2020 · 4 comments

Comments

@akeelnazir
Copy link

Please upgrade to the latest Angular deps. It doesn't work anymore. I was trying to follow the examples on your PS course :(

@duncanhunter
Copy link
Owner

Hi
Apologies for any issues. We are currently recording with a goal to finish by the end of June.
Can you share what did not work for you? Maybe we can do a small change in the meantime?

@akeelnazir
Copy link
Author

akeelnazir commented May 31, 2020

Node: v10.20.1
NPM: 6.14.4

Cloned repo and performed npm i, failed due to node-sass doing node-gyp. You can reproduce the issue easily by using the above mentioned node version and doing npm i.

It's unable to compile because it can't find module node-sass. Probably upgrading to a later version of @angular/cli might fix the issue.

@akeelnazir
Copy link
Author

I've fixed it in my branch, I can submit a PR if you give me access to do so.

Thanks

@duncanhunter
Copy link
Owner

My apologies I thought we where discussing my other course on NgRx. Thanks for the PR I will review and try and update more after we complete the other update. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants