Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow for smiley too #1

Closed
japhir opened this issue Sep 28, 2021 · 9 comments
Closed

Feature request: Allow for smiley too #1

japhir opened this issue Sep 28, 2021 · 9 comments

Comments

@japhir
Copy link

japhir commented Sep 28, 2021

Typing :) would be a nice addition!

@duckwork
Copy link
Owner

Is there a use-case for this? As far as I know, modes like electric-pair-mode only insert an extra (unwanted) closing pair when typing the open bracket -- so :) should be typable without intervention.

@alphapapa
Copy link
Contributor

Now, come on, there's clearly more duckwork to be done here: What if I want to type a smiley inside a set of parens, like (with | representing point):

I found a new package today called `frowny` (which, despite its name, brings a :|)

If I then insert a ), electric-pair-mode will skip past the ), leaving me with brings a :)|--and then the ) has to serve double-duty as both the mouth and closing paren, which isn't fair at all. It should clearly be brings a :)|) or brings a :) |).

The only question is whether this feature could possibly be considered in-scope for this package, given its name...

@d12frosted
Copy link

Off-topic. But I really need to say it - this package is amazing. Emacs community is amazing. You folks rock 💯

Not I am going to grab a shield for a well deserved rock for off-topic. See you! ❤️

@alphapapa
Copy link
Contributor

Off-topic. But I really need to say it - this package is amazing. Emacs community is amazing. You folks rock 100

acdw certainly brought an "unfrowny" to my face. :)

Not I am going to grab a shield for a well deserved rock for off-topic. See you! heart

Nah, no rocks, we'll just slap you gently with a wet squirrel. :)

@japhir
Copy link
Author

japhir commented Sep 29, 2021

Is there a use-case for this?

Ah, I guess my issue isn't because of electric-pair-mode but because I'm using smartparens' turn-on-smartparens-strict-mode. So when I try to type :) I get : and a message We can not insert unbalanced closing delimiter in strict mode.

@d12frosted
Copy link

@alphapapa had to show off my editing skills:

d7043aa5e46fc3062b6e4bc6c8d7c183

@alphapapa
Copy link
Contributor

@d12frosted LOL, quite the Gimpmaster you must be. :)

@duckwork
Copy link
Owner

Damn, yall are right about this. Okay, I'll include it in frowny -- expect an update later tonight!

(No, I won't make a new smiley package, because that's just silly :P )

@alphapapa
Copy link
Contributor

(No, I won't make a new smiley package, because that's just silly :P )

Well, that, and @tarsius might get the wrong idea... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants