Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Small bug in HN Spice - Need check for the "discussion" attribute #123

Closed
jagtalon opened this issue Feb 6, 2013 · 1 comment
Closed
Labels

Comments

@jagtalon
Copy link
Member

jagtalon commented Feb 6, 2013

Searching hn best blogging platform surprisingly gives no results.

However searching hn blogging platform gives results.

There seems to be a java script error in the first search due to a missing value in the json which has no check to make sure it exists!

It seems most "comments" have a discussion attribute which also have the title of the thread being commented on. However the second comment result from the first search is missing the discussion attribute.

Clearly a check is missing for the "discussion" attribute.

@majuscule
Copy link
Collaborator

closed in 99df928

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants