Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tespach/phishing detection tests #3222

Merged
merged 29 commits into from
Sep 9, 2024
Merged

Tespach/phishing detection tests #3222

merged 29 commits into from
Sep 9, 2024

Conversation

not-a-rootkit
Copy link
Collaborator

@not-a-rootkit not-a-rootkit commented Sep 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1208196336229421/f
Tech Design URL:
CC:

Description:
Implement test cases for phishing detection error page, tab extension, and privacy dashboard.

Steps to test this PR:

  1. Run the UnitTests + IntegrationTests
  2. Visit https://privacy-test-pages.site/security/badware/phishing.html
  3. Ensure warning is thrown
  4. Click through warning

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@not-a-rootkit not-a-rootkit changed the base branch from main to tespach/phishing-detection-integration September 5, 2024 16:48
@not-a-rootkit not-a-rootkit marked this pull request as ready for review September 6, 2024 08:45
@not-a-rootkit
Make integration tests more robust.
350b28d
@not-a-rootkit
Remove sleeps from tests.
e036f34
@not-a-rootkit
Fix redirect chains breaking error page navigation flows.
0faf308
@not-a-rootkit
Simplify - remove what should be in UI tests
d90bf24
@not-a-rootkit
Add feature disabled test case
f3b6954
@not-a-rootkit
Swiftlint fix
8d7f520
@not-a-rootkit
Replace .none reload with .redirect
e97623a
@not-a-rootkit
Add ErrorPageTabExtension tests for phishing
ec85c3f
@not-a-rootkit
Add DuckURLSchemeHandler tests
3923cf5
@not-a-rootkit
Simplify testDidNotLoadAndStartDataActivities_IfFeatureDisabled
b5e74f6
@not-a-rootkit
Remove duplicate tests
fa52d22
@not-a-rootkit
Add privacyDashboardIntegrationTest for phishingInfo
e103d7e
@not-a-rootkit
Remove duplicate PhishingDetection initialization
bf578d9
@not-a-rootkit
Test disable integration tests
25d4559
@not-a-rootkit
Revert .load and return .none instead of .redirect
03b77e7
@not-a-rootkit
Rewrite integration tests to look at tab.error instead of url
ee06b77
@not-a-rootkit
Refactor UnitTests to fix handling .load instead of .redirect.
132192d
@not-a-rootkit
Add extra checks to determine remote test failure.
ae0a792
@not-a-rootkit
Merge branch 'tespach/phishing-detection-integration' into tespach/ph…
717b052 
…ishing-detection-tests
@not-a-rootkit
Update featureFlagger references.
c49e0bb
@not-a-rootkit
Inject always-true feature flagger into PhishingDetection
7558e35
@not-a-rootkit
Inject PrivacyConfigManager
9fe5de9
@not-a-rootkit
Split redirect chain tests into two separate test cases
494c11c
@not-a-rootkit
Remove flaky tests- repeatedRedirectChains
7a07edc 
Too many navigation events in short succession.
@not-a-rootkit
Replace HTTP redirect chain test.
ee19078
@not-a-rootkit
Use privacy-test-pages.site as test origin.
fdef653
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 0b89b22

SabrinaTardio
SabrinaTardio approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I just suggested some improvements

IntegrationTests/PhishingDetection/PhishingDetectionIntegrationTests.swift Outdated Show resolved Hide resolved
IntegrationTests/PhishingDetection/PhishingDetectionIntegrationTests.swift Show resolved Hide resolved
UnitTests/DuckSchemeHandler/DuckSchemeHandlerTests.swift Show resolved Hide resolved
UnitTests/DuckSchemeHandler/DuckSchemeHandlerTests.swift Show resolved Hide resolved
UnitTests/TabExtensionsTests/ErrorPageTabExtensionTest.swift Show resolved Hide resolved
@not-a-rootkit not-a-rootkit merged commit 1c75030 into tespach/phishing-detection-integration Sep 9, 2024
18 checks passed
@not-a-rootkit not-a-rootkit deleted the tespach/phishing-detection-tests branch September 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabrinaTardio SabrinaTardio SabrinaTardio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-a-rootkit @SabrinaTardio