Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply translations for zoom text #3583

Merged
merged 3 commits into from
Nov 15, 2024
Merged

apply translations for zoom text #3583

merged 3 commits into from
Nov 15, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Nov 15, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1208623380535818/f
Tech Design URL:
CC:

Description:
Applies translations for the zoom text feature.

Steps to test this PR:

  1. Run the app and check a few different languages.
  2. Smoke text zoom text functionality:
  • Change the zoom text from the browsing menu
  • Change the zoom text in settings

@brindy brindy requested a review from miasma13 November 15, 2024 16:33
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides inconsistencies for PL and ET in "Zoom" vs "Zoom (d%)" all is good.

Comment on lines 23 to 26
"action.text-zoom-menu-item" = "Suurendus (%d%%)";

/* Text zoom menu item */
"action.text-zoom-sheet-menu-item" = "Zoom";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are not variants of the same - l:26 should be Suurendus

Comment on lines 23 to 26
"action.text-zoom-menu-item" = "Powiększenie (%d%%)";

/* Text zoom menu item */
"action.text-zoom-sheet-menu-item" = "Zoom";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are not consistent, l:26 should be "Powiększenie"

@brindy brindy merged commit a255082 into main Nov 15, 2024
13 checks passed
@brindy brindy deleted the brindy/text-zoom-translations branch November 15, 2024 18:36
samsymons added a commit that referenced this pull request Nov 21, 2024
…g-error

* main:
  Wrap subscription-related navigation links in `LazyView` (#3576)
  Set `dryRun` for VPN and alpha pixels (#3578)
  apply translations for zoom text (#3583)
  Prevent sending duplicate home tab pixel (#3580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants