Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Add To Dock Translations #3566

Merged

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1208739475947574/f

Description:

Import Add To Dock translations

Steps to test this PR:

Prerequisites:

  1. Ensure that isOnboardingHighlightsEnabled returns true in OnboardingManager.
  2. Add return VariantIOS(name: "mx", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntroHighlights, .contextualDaxDialogs]) in DefaultVariantManager -> selectVariant() at line 156.

Scenario 1 - Add to Dock is presented from linear onboarding

  1. Ensure that addToDockEnabledState returns .intro in OnboardingManager.
  2. Select one of the supported languages in the App Scheme.
  3. Launch the App and start onboarding flow.
  4. Ensure the Add To Dock strings are translated.

Scenario 2 - Add to Dock is presented from contextual onboarding

  1. Ensure that addToDockEnabledState returns .contextual in OnboardingManager.
  2. Select one of the supported languages in the App Scheme.
  3. Launch the App and complete the contextual onboarding flow.
  4. Ensure the Add To Dock strings are translated.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 57c27b3

Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Italian… all translated

@alessandroboron alessandroboron merged commit 67449e1 into main Nov 12, 2024
16 checks passed
@alessandroboron alessandroboron deleted the alessandro/onboarding-add-to-dock-translations branch November 12, 2024 14:57
samsymons added a commit that referenced this pull request Nov 13, 2024
* main:
  Release 7.145.0-2 (#3570)
  Fix favorites grid layout issues on New Tab Page (#3568)
  Import Add To Dock Translations (#3566)
  Release 7.145.0-1 (#3567)
  Remove Old onboarding intro (#3554)
  fix showing current tab in suggestions (#3562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants