Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old onboarding intro #3554

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Remove Old onboarding intro #3554

merged 4 commits into from
Nov 12, 2024

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Nov 7, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208711411340874/f

Description:

Remove the old onboarding for returning users as discussed in Asana.

Steps to test this PR:

  1. Add return VariantIOS.returningUser in DefaultVariantManager- >selectVariant()` at line 156.
  2. Launch the App.
  3. Ensure that Onboarding intro flow is the new one.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

brindy
brindy approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, RIP old onboarding ⚰️

@alessandroboron alessandroboron changed the base branch from main to release/7.145.0 November 11, 2024 16:49
@alessandroboron alessandroboron merged commit 1fd625f into release/7.145.0 Nov 12, 2024
18 checks passed
@alessandroboron alessandroboron deleted the alessandro/onboarding-add-to-dock-remove-old-onboarding branch November 12, 2024 13:29
samsymons added a commit that referenced this pull request Nov 13, 2024
@samsymons
Merge branch 'main' into dominik/xcode-16
7f9ac0e 
* main:
  Release 7.145.0-2 (#3570)
  Fix favorites grid layout issues on New Tab Page (#3568)
  Import Add To Dock Translations (#3566)
  Release 7.145.0-1 (#3567)
  Remove Old onboarding intro (#3554)
  fix showing current tab in suggestions (#3562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandroboron @brindy