Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HomePageViewController code #3454

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Remove HomePageViewController code #3454

merged 5 commits into from
Oct 29, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Oct 18, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208547223289954/f
Tech Design URL:
CC: @brindy

Description:

This is a follow up after #3453.

Removes unused code related to HomePageViewController. Home renderers abstraction was also removed, though the implementation itself is used in both Bookmarks controller and to show Favorites while editing URL on non-home tab.

Steps to test this PR:

  1. Make sure code compiles and tests pass.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 0653f8e

Base automatically changed from mariusz/ntp-cleanup to main October 23, 2024 15:31
@dus7 dus7 force-pushed the mariusz/remove-old-home-code branch from 9eb444c to 0653f8e Compare October 25, 2024 08:08
@dus7 dus7 marked this pull request as ready for review October 25, 2024 08:13
@dus7 dus7 requested review from a team and federicocappelli and removed request for a team October 25, 2024 08:43
@federicocappelli
Copy link
Member

Hi @dus7 I have no context about these changes and the task is empty, could you provide some info and testing steps?
I see business logic and UI changes, should the PR contain the steps for testing the involved features?

dus7
dus7 commented Oct 25, 2024
View reviewed changes
DuckDuckGo/HomeMessageViewModel.swift
@@ -169,3 +169,12 @@ struct HomeMessageButtonViewModel {
let action: () async -> Void

}

private extension RemoteAction {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted out of HomeMessageViewSectionRenderer.swift which was deleted.

DuckDuckGo/FavoritesHomeViewSectionRenderer.swift
@@ -83,13 +84,6 @@ class FavoritesHomeViewSectionRenderer: NSObject, HomeViewSectionRenderer {
return Constants.defaultHeaderHeight
}

func install(into controller: HomeViewController) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is no longer necessary since there is no HomeViewController.

DuckDuckGo/FavoritesHomeViewSectionRenderer.swift
@@ -43,7 +43,8 @@ class FavoritesHomeViewSectionRenderer: NSObject, HomeViewSectionRenderer {
static let defaultHeaderHeight: CGFloat = 20
static let horizontalMargin: CGFloat = 2
static let largeModeMargin: CGFloat = 24

static let sideInsets: CGFloat = 25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted from HomeViewSectionRenderers.swift file which was deleted.

DuckDuckGo/HomePageConfiguration.swift
@@ -27,21 +27,6 @@ import os.log

final class HomePageConfiguration: HomePageMessagesConfiguration {

enum Component: Equatable {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since it was used only by HomeViewController which is also removed.

@dus7
Copy link
Contributor Author

dus7 commented Oct 25, 2024

Hi @dus7 I have no context about these changes and the task is empty, could you provide some info and testing steps? I see business logic and UI changes, should the PR contain the steps for testing the involved features?

Hi, I added a few inline comments and an initial PR link in the description. This PR does not cause any UI and/or logic changes. All the modifications were done in previous one (#3453). This is just removing unused code.

federicocappelli
federicocappelli approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a question: I see that we removed a few translated strings, should we run a translation step in order to remove the strings from the Smartling DB? did you already do it?

@dus7
Copy link
Contributor Author

dus7 commented Oct 28, 2024

LGTM Just a question: I see that we removed a few translated strings, should we run a translation step in order to remove the strings from the Smartling DB? did you already do it?

Thanks. I tried, but I can't do it since there are no "new" strings and I'm not able to continue in Smartling. It should sort itself out with next translations job I presume.

@dus7 dus7 merged commit 199de4d into main Oct 29, 2024
31 of 32 checks passed
@dus7 dus7 deleted the mariusz/remove-old-home-code branch October 29, 2024 08:34
samsymons added a commit that referenced this pull request Oct 30, 2024
@samsymons
Merge branch 'main' into dominik/xcode-16
0865e5e 
* main:
  adding impression pixels for duckplayer in landscape mode (#3493)
  Update autoconsent to v10.17.0 (#3504)
  Onboarding Add to Dock Tutorial (#3482)
  Blind attempt to fix Omnibar-related crash (#3500)
  Add to Dock Localised strings (#3494)
  Add to Dock Onboarding feature flag (#3476)
  Remove HomePageViewController code (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicocappelli federicocappelli federicocappelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dus7 @federicocappelli