Fix failing password-management maestro test #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
changed the title
graeme
approved these changes
Oct 4, 2024
samsymons
added a commit
that referenced
this pull request
Oct 9, 2024
* main: Update BSK version to support userTips NetP Flag (#3416) Release 7.140.0-0 (#3418) Adds new debug screen to view raw credentials data (#3400) Bump rollup from 2.79.1 to 3.29.5 (#3385) fix UI tests broken by tabs suggestions (#3402) Fix ability to edit Synced device name (#3404) Fix failing password-management maestro test (#3413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208448205292549/f
Tech Design URL:
CC:
Description:
Fixes issue where including a swiftUI component in the tableview header caused a maestro crash as too many accessibility layout updates fired while animating from search controller results view back to normal table layout. I also improved the accessibility of the Sync Promo (setting irrelevant UI elements as hidden, accessibility labels on buttons etc)
Steps to test this PR:
password-managementtest flow completed successfully https://github.com/duckduckgo/iOS/actions/runs/11159554690/job/31018490538Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template