Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to edit Synced device name #3404

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix ability to edit Synced device name #3404

merged 1 commit into from
Oct 4, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 27, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1201493110486074/1208413262127358/f
Tech Design URL:
CC:

Description:
Fixes bug which caused the edit synced device name & remove synced devices screens to dismiss as soon as they were presented due to multiple spurious presentation attempts firing

Steps to test this PR:

  1. Go to Sync settings & sync with another device (if not already)
  2. From the list of synced devices, tap the “This Device” row
  3. Confirm the prompt presents correctly and that you can modify the device name
  4. Tap a device you are synced with
  5. Confirm the Remove Device prompt presents correctly & that removing the device works

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than ’

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

—

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from graeme October 2, 2024 15:07
@amddg44 amddg44 merged commit 477ec85 into main Oct 4, 2024
26 checks passed
@amddg44 amddg44 deleted the anya/fix-sync-edit-device-name branch October 4, 2024 14:43
samsymons added a commit that referenced this pull request Oct 9, 2024
@samsymons
Merge branch 'main' into sam/persistent-pixels
aacc4dc 
* main:
  Update BSK version to support userTips NetP Flag (#3416)
  Release 7.140.0-0 (#3418)
  Adds new debug screen to view raw credentials data (#3400)
  Bump rollup from 2.79.1 to 3.29.5 (#3385)
  fix UI tests broken by tabs suggestions (#3402)
  Fix ability to edit Synced device name (#3404)
  Fix failing password-management maestro test (#3413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amddg44 @graeme