Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Punycode 3.0.0 #3370

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Upgrade to Punycode 3.0.0 #3370

merged 2 commits into from
Sep 23, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Sep 19, 2024

Task/Issue URL: https://app.asana.com/0/1200194497630846/1208348353779307/f

Description:
This change upgrades Punycode to the latest release.

Steps to test this PR:

  1. Verify that CI is green.
  2. Smoke test punycode-encoded URLs handling in iOS and macOS apps.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Sep 19, 2024
@ayoy ayoy marked this pull request as ready for review September 19, 2024 08:24
@ayoy ayoy assigned mallexxx and unassigned ayoy Sep 19, 2024
@ayoy ayoy requested a review from mallexxx September 19, 2024 08:25
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit 8fa946e into main Sep 23, 2024
13 checks passed
@ayoy ayoy deleted the dominik/punycode-3.0.0 branch September 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants