Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reapply auto clear fix, clear cookies, load page on link click #2798

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 26, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207169339530592/f
Tech Design URL:
CC:

Description:

Reapply a fix which caused an incident, but with a fix to clear the cookies on clear.

Steps to test this PR:
Setup

  1. Set auto clear and timing of 5 minutes (hack the code to change this to a smaller value, e.g. 10 seconds)
  2. Set as default browser

App Termination

  1. Login to reddit (save the login and add a favorite to save time in the next tests)
  2. Force close the app
  3. Launch
  • tabs should be cleared
  • Go to reddit.com - should be logged out.

Expiry

  1. Login to reddit
  2. Background the app
  3. Wait for the time to expire
  4. Launch
  • tabs should be cleared
  • Go to reddit.com - should be logged out.

Open Link from other app

  1. Login to reddit
  2. Background the app
  3. Wait for the time to expire
  4. Click on link from other app (e.g. iMessage or sharing from Safari, etc) -
  • tabs should be cleared
  • new tab should be open with URL in link and will load
  • Go to reddit.com - should be logged out.

@brindy brindy changed the title reapply auto clear fix, clear cookies, launch page on open tab reapply auto clear fix, clear cookies, load page on link click Apr 26, 2024
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the test steps and this all worked for me, and I wasn't able to reproduce any of the issues reported in the original task. Let's give it a try 👍

@brindy brindy merged commit 7999941 into main Apr 28, 2024
19 checks passed
@brindy brindy deleted the brindy/reapply-tab-manager-fix branch April 28, 2024 10:55
samsymons added a commit that referenced this pull request Apr 30, 2024
* main: (38 commits)
  Disable the feedback send button when there’s no text (#2800)
  Release 7.118.0-0 (#2802)
  Autofill Settings - Import passwords via sync (#2756)
  Fix selected VPN location consistency (#2797)
  Reapply "Report Apple Ad attribution using pixel" (#2702)
  reapply auto clear fix, clear cookies, load page on link click (#2798)
  Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants