Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that shows selected tab in strange position in the switcher #2789

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 25, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207153191136827/f
Tech Design URL:
CC:

Description:

Fix bug that shows selected tab in strange position in the switcher

Steps to test this PR:

  1. Open a new few tabs on various pages
  2. Use the tab switcher, ensure the current tab is as central as it can be
  3. Change tab switcher modes and retest
  4. Also check the two options when going between home pages

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 25, 2024
@brindy brindy requested a review from amddg44 April 25, 2024 09:54
@brindy brindy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 25, 2024
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on iPhone & iPad in both switcher modes, portrait & landscape; one and many tabs, all perfect!

@brindy brindy merged commit 1cfe98a into main Apr 26, 2024
17 of 18 checks passed
@brindy brindy deleted the brindy/tab-switcher-tab-position branch April 26, 2024 08:54
samsymons added a commit that referenced this pull request Apr 26, 2024
…utdown

# By Christopher Brind (4) and others
# Via Chris Brind (1) and others
* main: (21 commits)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  iOS: Bundle-Specfic Autofill Secure Vault Keychain Items  (#2759)
  Fix dSYM archive upload to S3 (#2778)
  Fix dSYM archive upload to S3 (#2778)
  Release 7.117.0-0 (#2776)
  Select Subscription Environment in Debug Settings (#2766)
  lastDisconnectError now matches against NEVPNConnectionError (#2753)
  Release 7.116.0-3 (#2774)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Apr 30, 2024
* main: (38 commits)
  Disable the feedback send button when there’s no text (#2800)
  Release 7.118.0-0 (#2802)
  Autofill Settings - Import passwords via sync (#2756)
  Fix selected VPN location consistency (#2797)
  Reapply "Report Apple Ad attribution using pixel" (#2702)
  reapply auto clear fix, clear cookies, load page on link click (#2798)
  Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants