Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Subscription Environment in Debug Settings #2766

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Apr 19, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207000309125344/f

Description:

  • Adds a debug setting to change Subscription Environment
  • Always use Production Environment by default

Steps to test this PR:

  1. Uninstall App
  2. Install and make yourself an internal user
  3. Go to Debug > Subscriptions
  4. Confirm Environment is set to Production
  5. Change to Staging
  6. Restore a Staging Account (using email)
  7. Smoke test subscription
  8. Restart App (Build and run)
  9. Confirm environment is still staging
  10. Change environment to Production
  11. Confirm you're logged out
  12. Try restore the same account via email
  13. You'll never get the OTP
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep marked this pull request as draft April 19, 2024 17:52
@afterxleep afterxleep marked this pull request as ready for review April 22, 2024 13:48
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afterxleep afterxleep merged commit 761d98b into main Apr 23, 2024
13 checks passed
@afterxleep afterxleep deleted the daniel/subscription/env.selection branch April 23, 2024 10:08
samsymons added a commit that referenced this pull request Apr 26, 2024
# By Dominik Kapusta (3) and others
# Via GitHub (1) and amddg44 (1)
* main:
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  iOS: Bundle-Specfic Autofill Secure Vault Keychain Items  (#2759)
  Fix dSYM archive upload to S3 (#2778)
  Fix dSYM archive upload to S3 (#2778)
  Release 7.117.0-0 (#2776)
  Select Subscription Environment in Debug Settings (#2766)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
samsymons added a commit that referenced this pull request Apr 26, 2024
…utdown

# By Christopher Brind (4) and others
# Via Chris Brind (1) and others
* main: (21 commits)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  iOS: Bundle-Specfic Autofill Secure Vault Keychain Items  (#2759)
  Fix dSYM archive upload to S3 (#2778)
  Fix dSYM archive upload to S3 (#2778)
  Release 7.117.0-0 (#2776)
  Select Subscription Environment in Debug Settings (#2766)
  lastDisconnectError now matches against NEVPNConnectionError (#2753)
  Release 7.116.0-3 (#2774)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants