-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofill Settings - Import passwords via sync #2756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DesktopDownloadViewButtonStyle
…via-sync # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
…nitial unit tests
aataraxiaa
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Anya! 🚀 Tested all functionality and Pixels.
Left a couple of super small suggestions. (The one about unnecessary return
statements could apply to a few places in the code, but I didn’t comment at each as you may want to disregard the suggestion)
…via-sync # Conflicts: # DuckDuckGo/UserText.swift
samsymons
added a commit
that referenced
this pull request
Apr 30, 2024
* main: (38 commits) Disable the feedback send button when there’s no text (#2800) Release 7.118.0-0 (#2802) Autofill Settings - Import passwords via sync (#2756) Fix selected VPN location consistency (#2797) Reapply "Report Apple Ad attribution using pixel" (#2702) reapply auto clear fix, clear cookies, load page on link click (#2798) Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1206531758082871/f
Tech Design URL:
CC:
Description:
Gives users a path to import passwords via importing on desktop and enabling sync
Steps to test this PR:
m.autofill.logins.import.no.passwords
firesm.autofill.logins.import.no-action
is firedm.autofill.logins.import.get.desktop
firesm.get.desktop.copy
is firedm.get.desktop.share
is firedm.autofill.logins.import.sync
firesm.autofill.logins.import
is firedm.autofill.logins.import.success
is firedCopy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template