Check entitlements before showing VPN screen from notification #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
quanganhdo
approved these changes
Apr 16, 2024
graeme
removed
the
bot: not in app board
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
# By Dominik Kapusta (3) and others # Via GitHub (1) and amddg44 (1) * main: fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) iOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2759) Fix dSYM archive upload to S3 (#2778) Fix dSYM archive upload to S3 (#2778) Release 7.117.0-0 (#2776) Select Subscription Environment in Debug Settings (#2766) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Christopher Brind (4) and others # Via Chris Brind (1) and others * main: (21 commits) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) iOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2759) Fix dSYM archive upload to S3 (#2778) Fix dSYM archive upload to S3 (#2778) Release 7.117.0-0 (#2776) Select Subscription Environment in Debug Settings (#2766) lastDisconnectError now matches against NEVPNConnectionError (#2753) Release 7.116.0-3 (#2774) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Apr 30, 2024
* main: (38 commits) Disable the feedback send button when there’s no text (#2800) Release 7.118.0-0 (#2802) Autofill Settings - Import passwords via sync (#2756) Fix selected VPN location consistency (#2797) Reapply "Report Apple Ad attribution using pixel" (#2702) reapply auto clear fix, clear cookies, load page on link click (#2798) Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207077903361923/f
Description:
Found an issue where you can still launch the VPN controls screen after signing out of Privacy Pro by tapping an old notification. Not much impact as the VPN won’t work without a token, but worth fixing nonetheless.
Steps to test this PR:
Expected:
The app should be launched but not the VPN controls
Observed:
VPN controls are shown
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template