Delete statement #11
Delete statement #11
Conversation
|
@Tmonster could you please review this PR? |
| @@ -16,15 +16,17 @@ jobs: | |||
| name: Build extension binaries | |||
| uses: duckdb/extension-ci-tools/.github/workflows/[email protected] | |||
| with: | |||
| duckdb_version: main | |||
| duckdb_version: v1.0.0 | |||
There was a problem hiding this comment.
is this not already done? Or was this done earlier and now you are just reverting it?
There was a problem hiding this comment.
Previously we changed it with @carlopi to main and current changes are came from the @samansmink recommendation to match this file to delta extension's along with removing the _extension_deploy.yml
There was a problem hiding this comment.
One thing: I think it make sense to have the duckdb submodule match what CI compiles
If sqlsmith should strive to be compatible both with v1.0.0 and main, I would have 2 CI jobs (or 2 sections of the same yml file) compile for both cases.
There was a problem hiding this comment.
I would have 2 CI jobs (or 2 sections of the same yml file) compile for both cases.
Do you mean one for the current stable version of the submodule duckdb and one for some another version? I'm not sure I got it, how should it be changed
| # this workflow can be configured to use a custom deploy script. | ||
|
|
||
|
|
||
| name: Extension Deployment |
There was a problem hiding this comment.
Why is this file getting deleted? Can you update the PR description?
|
Looks like the duckdb submodule is being updated? Is that still necessary? It should point to v1.0.0 already right? |
hmeriann
force-pushed
the
delete-statement
branch
from
8807b56 to
858a37e
Compare
You are right, threw that commit out |
|
LGTM, can you resolve the merge conflicts? |
fix indentation added two more jobs to build and deploy main version Update .github/workflows/MainDistributionPipeline.yml Co-authored-by: Carlo Piovesan <[email protected]>
hmeriann
force-pushed
the
delete-statement
branch
from
6b27c0f to
8e676a2
Compare
This PR adds GenerateDelete() to Statement Generator.
This function generates the DELETE_STATEMENT for one of the tables from the context or based on the randomly generated table references.
What's more, this PR removes
.github/workflows/_extension_deploy.ymlfile and updates.github/workflows/MainDistributionPipeline.ymlto use the_extension_deploy.ymlfrom theextension-ci-toolsinstead of a local copy, as @samansmink recommended to do. Also thewasm_mvp;wasm_eh;wasm_threads and windows_amd64_rtoolsare skipped for now.