Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Actions does not work when detekt plugin is also enabled #270

Closed
marco-eckstein opened this issue Oct 22, 2019 · 4 comments
Closed

Comments

@marco-eckstein
Copy link

marco-eckstein commented Oct 22, 2019

Save Actions does not work when the detekt plugin is also installed and enabled. This may be a bug in either plugin See other plugin's issue.

@arturbosch
Copy link

arturbosch commented Oct 24, 2019

Hm, thanks for the report. Do you use the autoCorrect feature together with the formatting option?
It might be that they concurrently overwriting the files content.
Edit: ups wrong but also right issue :)

@dubreuia
Copy link
Owner

Hey @marco-eckstein, thank you for the issue. Hello @arturbosch, fellow plugin developer :D

Like @arturbosch said, probably the detekt plugin overrides the file previously saved by the save-actions plugin. I see a saveDocument here https://github.com/arturbosch/detekt-intellij-plugin/blob/f840b0c58d084c78d26e7436220303a9a41094bc/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektAnnotator.kt#L48. Not sure the best way to fix this.

@dubreuia dubreuia added the bug label Oct 24, 2019
@marco-eckstein
Copy link
Author

No, the autocorrect feature is disabled. Just installing and enabling the detekt plugin is enough to break Save Actions.

@dubreuia
Copy link
Owner

Is this still an issue? If yes reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants