Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method call beforeAllDocumentsSave do not return unsaved documents #224

Closed
N3XT0R opened this issue Jan 31, 2019 · 5 comments
Closed

Method call beforeAllDocumentsSave do not return unsaved documents #224

N3XT0R opened this issue Jan 31, 2019 · 5 comments

Comments

@N3XT0R
Copy link

N3XT0R commented Jan 31, 2019

Describe the bug
Hello Guys, since i've updated to version 1.4 of this plugin inside of PhpStorm, the save action do nothing anymore.

To Reproduce
Look at the screenshot for configuration.

Expected behavior
Normally it should reformat the sourcecode on save.

Screenshots (optional)
If applicable, add screenshots to help explain your problem.
image

Versions
PhpStorm 2018.3.3
Build #PS-183.5153.36, built on January 9, 2019
Licensed to Alpha Online Service GmbH / Ilya Beliaev
Subscription is active until September 19, 2019
JRE: 1.8.0_152-release-1343-b26 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Attachments

`

`

Attach 2 files from https://github.com/dubreuia/intellij-plugin-save-actions#files-location

@dubreuia
Copy link
Owner

dubreuia commented Feb 4, 2019

I'll need more info, can you send me a copy of your "idea.log" (https://github.com/dubreuia/intellij-plugin-save-actions#files-location). You can filter the lines that do not belong to the plugin with sed -n '/SaveActionManager/p' idea.log.

Also, are you sure it doesn't work? Test this: modify a file, click in another window (like here), then return to the IDE, and check if your code is formatted.

@N3XT0R
Copy link
Author

N3XT0R commented Feb 4, 2019

Following content is inside the idea.log-file:

$ sed -n '/SaveActionManager/p' idea.log                                                                                                                                                                                                                                        2019-02-04 14:15:17,916 [16885470]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:15:17,916 [16885470]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14:17:54,035 [17041589]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14:17:54,035 [17041589]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:17:54,035 [17041589]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14: 20:21,149 [17188703]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14: 20:21,149 [17188703]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14: 20:21,149 [17188703]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14:22:01,726 [17289280]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14:22:01,726 [17289280]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:22:01,726 [17289280]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14:23:02,250 [17349804]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14:23:02,250 [17349804]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:23:02,250 [17349804]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14:23:21,221 [17368775]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14:23:21,221 [17368775]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:23:21,221 [17368775]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents
2019-02-04 14:24:26,527 [17434081]   INFO - re.component.SaveActionManager - [+] Start SaveActionManager#beforeAllDocumentsSaving
2019-02-04 14:24:26,527 [17434081]   INFO - re.component.SaveActionManager - Unsaved documents (0): []
2019-02-04 14:24:26,527 [17434081]   INFO - re.component.SaveActionManager - End SaveActionManager#beforeAllDocumentsSaving processed 0 documents

And i am sure that it doesnt work. When i am trying to save a file, click into another window and switch back to the IDE no changes are done.

@dubreuia
Copy link
Owner

dubreuia commented Feb 4, 2019

I have an idea, working on a fix but I'm unsure if it will fix it or not. What plugins are you using? IdeaVim?

@dubreuia dubreuia changed the title save actions - save action do nothing Method call beforeAllDocuments save do not return unsaved documents Feb 4, 2019
@dubreuia dubreuia changed the title Method call beforeAllDocuments save do not return unsaved documents Method call beforeAllDocumentsSave do not return unsaved documents Feb 4, 2019
@N3XT0R
Copy link
Author

N3XT0R commented Feb 4, 2019

image

@dubreuia
Copy link
Owner

Duplicates #222

@dubreuia dubreuia added duplicate and removed bug labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants