Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Issue on UTM Drawer when user clicks cancel on Mobile #1624

Open
FaheemOnHub opened this issue Oct 23, 2024 · 7 comments · May be fixed by #1748
Open

UI Issue on UTM Drawer when user clicks cancel on Mobile #1624

FaheemOnHub opened this issue Oct 23, 2024 · 7 comments · May be fixed by #1748

Comments

@FaheemOnHub
Copy link

Issue Summary
When accessing on Mobile, after the user click create link and adds the details, incase the user clicks on UTM Button and cancels, the whole create link operation gets cancelled.This issue causes problem for the user while creating link.

Steps to Reproduce

  1. Open the app on mobile device
  2. Click create link and add details
  3. Click on UTM and press cancel
  4. It will throw the user to main whereas it should go back to create link page where the added details should be present.

Expected behavior

In case the user pressed cancel inside the UTM, the app should go back to the create-link page where the user has already added details of the link.

kindly assign this issue to me

Screenshots/Videos

Screen.Recording.2024-10-24.at.12.23.05.AM.mov

Version info
Tested on both:

iPhone 15 iOS 17
Edge Version 130.0.2849.46 (Official build) (arm64)

Copy link

linear bot commented Oct 23, 2024

Copy link

oss-gg bot commented Oct 23, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@steven-tey
Copy link
Collaborator

/award 150 thanks for the bug report!

Copy link

oss-gg bot commented Oct 27, 2024

Awarding FaheemOnHub: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/FaheemOnHub

@Hustler-Sameer
Copy link

@steven-tey Hey , if you have any new good first issues , please let me know

@unrenamed
Copy link
Contributor

@Hustler-Sameer I believe I might have identified the root cause of this issue today, and it seems to be closely related to a similar issue I addressed in this PR, which fixes a bug with toasts. Given that this involves understanding how Vaul Drawer is designed and integrated into Dub, it might not be the most straightforward task for someone unfamiliar with the system.

@steven-tey, if you'd like, I’d be happy to take this on and submit a PR with both a potential solution and an alternative approach, along with my analysis.

@FaheemOnHub FaheemOnHub removed their assignment Nov 20, 2024
@steven-tey
Copy link
Collaborator

Sure thing, go for it @unrenamed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants