fix: fix read split buffer function gr block bug #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceLiZhixin
force-pushed
the
readsplitbuffer-gr-block
branch
from
f5e017a
to
131170d
Compare
justxuewei
reviewed
Aug 12, 2021
| @@ -36,6 +38,7 @@ import ( | |||
| _ "dubbo.apache.org/dubbo-go/v3/registry/protocol" | |||
| _ "dubbo.apache.org/dubbo-go/v3/registry/zookeeper" | |||
| "go.uber.org/atomic" | |||
| _ "net/http/pprof" | |||
There was a problem hiding this comment.
maybe, you should move this line to 1st block
| @@ -36,6 +38,8 @@ import ( | |||
| _ "dubbo.apache.org/dubbo-go/v3/registry/nacos" | |||
| _ "dubbo.apache.org/dubbo-go/v3/registry/protocol" | |||
| _ "dubbo.apache.org/dubbo-go/v3/registry/zookeeper" | |||
|
|
|||
| _ "net/http/pprof" | |||
|
LGTM |
LaurenceLiZhixin
force-pushed
the
readsplitbuffer-gr-block
branch
from
131170d
to
66d87bc
Compare
LaurenceLiZhixin
force-pushed
the
readsplitbuffer-gr-block
branch
from
66d87bc
to
70d8030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When I using pprof to check gr leak bug, I found that function
readSplitDatawould block when gr pool full. And I solve it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: