Stop node from using P2PKH outputs for staking #1002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Sumberaz <[email protected]>
frolosofsky
reviewed
Apr 17, 2019
frolosofsky
reviewed
Apr 17, 2019
Signed-off-by: Matteo Sumberaz <[email protected]>
Gnappuraz
commented
Apr 17, 2019
dsaveliev
reviewed
Apr 17, 2019
Signed-off-by: Matteo Sumberaz <[email protected]>
dsaveliev
approved these changes
Apr 17, 2019
kostyantyn
reviewed
Apr 17, 2019
| for i in range(0, len(nodes)): | ||
| if i+1 < len(nodes): | ||
| disconnect_nodes_bi(nodes, i, i + 1) | ||
|
|
There was a problem hiding this comment.
Not sure I understood the usage of this function but let's say if node 0 is connected to node 2, they won't be disconnected.
Shouldn't it be:
for (a, b) in itertools.combinations(nodes, 2):
disconnect_nodes_bi(nodes, a, b)
Signed-off-by: Matteo Sumberaz <[email protected]>
|
This PR breaks a lot of tests still relying on P2PKH being a stakeable coin. This work is continued in another PR #1025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
GetStakeableCoins()still returns P2PKH coins, that we cannot use to sign a segwit coinbase. This leads to nodes creating blocks but then discarding them because they can't sign them.Fixes #997