Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #[error(fmt = ...)] #367

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Implement #[error(fmt = ...)] #367

merged 2 commits into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. Implement #[error(fmt = ...)]

    @dtolnay
    dtolnay committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ba9af45 View commit details
    Browse the repository at this point in the history

  2. Ignore trivially_copy_pass_by_ref pedantic clippy lint in test 

        warning: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
       --> tests/test_display.rs:388:16
        |
    388 |     fn pair(k: &i32, v: &i32, formatter: &mut fmt::Formatter) -> fmt::Result {
        |                ^^^^ help: consider passing by value instead: `i32`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
        = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic`
        = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

    warning: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
       --> tests/test_display.rs:388:25
        |
    388 |     fn pair(k: &i32, v: &i32, formatter: &mut fmt::Formatter) -> fmt::Result {
        |                         ^^^^ help: consider passing by value instead: `i32`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
    @dtolnay
    dtolnay committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8311380 View commit details
    Browse the repository at this point in the history