Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

don't let a hyphen ruin an ident party #15

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

softprops
Copy link
Contributor

fixes #14

Was motivated to grab this because I'll likely run into this sooner for my particular mashup use case.

@softprops
Copy link
Contributor Author

ha! actually I ran into this immediately after putting the latest mashup to the test for my use case.

I'm using rust to deploy serverless aws lambda functions. A motivation for seeking out a crate like mashup was the awkwardness of not being able to use concat_idents! ( or strings even if that was stable ) for providing cpython identifiers. This builds off of the crowbar lambda crate which has the same limitation so by default crate lib's for crowbar/lambda must be named lambda out of expectation.

I put mashup to the test and that works as expected... except when crate names have hyphens, just like a my serverless template repo does :)

What are the chances of this getting merged and released within the next few days? That would unblock my confidence and pushing my original usecase forward. Less potential footguns!

@dtolnay dtolnay merged commit 98d11ec into dtolnay:master Oct 5, 2018
@softprops
Copy link
Contributor Author

thanks again @dtolnay!

@softprops
Copy link
Contributor Author

following to to confirm, this fixed worked like a charm with my use case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace - with _ in environment variables
2 participants