Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why upgrading to a major version of syn when releasing a patch version of inherent? #18

Closed
billy1624 opened this issue Mar 20, 2023 · 4 comments
Closed

Why upgrading to a major version of syn when releasing a patch version of inherent? #18

billy1624 opened this issue Mar 20, 2023 · 4 comments

Comments

@billy1624
Copy link

As title. I guess syn v2 split more types into feature guarded module compared with syn v1?

The affected CI: https://github.com/SeaQL/sea-query/actions/runs/4462345887/jobs/7836825695
@billy1624
Copy link
Author

Interesting. Seems thiserror also upgraded to syn v2 in recent patch release.

@billy1624
Copy link
Author

Hey @dtolnay, I'm writing to inform and see if it's intentional or not. Appreciated to what you did for the Rust community. Cheers!! :)

@billy1624
Copy link
Author

UPDATE: the root cause of the failing CI is documented here SeaQL/sea-query#624

@dtolnay
Copy link
Owner

dtolnay commented Mar 20, 2023

Seems like this was a bug in sea-query.

@dtolnay dtolnay closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtolnay @billy1624