Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log everything to stdout #115

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Log everything to stdout #115

merged 1 commit into from
Sep 25, 2023

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Sep 24, 2023

No description provided.

@Rembane
Simplify logging by sending all logs to stdout
5a999f4 
Before this change, the data updater logs were sent to a file set in the
configuration of the application, which more or less hid the logs there.
Meanwhile the access logs were sent to stdout. Now both kinds of logs
are sent to stdout which makes it much easier for the programs hosting
mat to read and parse the logs.

Close #63.
@Rembane Rembane linked an issue Sep 24, 2023 that may be closed by this pull request
Add stdout as possible log target #63
Closed
@Rembane Rembane requested a review from a team September 24, 2023 17:02
Rembane
Rembane commented Sep 24, 2023
View reviewed changes
app/Main.hs Show resolved Hide resolved
The1Penguin
The1Penguin approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@The1Penguin The1Penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes more sense to log to stdout when having it as a docker container, which is the use case

@Rembane Rembane merged commit 73b474e into main Sep 25, 2023
2 checks passed
@Rembane Rembane deleted the 63-add-stdout-as-possible-log-target branch September 25, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The1Penguin The1Penguin The1Penguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stdout as possible log target
2 participants
@Rembane @The1Penguin