Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenVxMask wrapper to require setting -type #960

Closed
20 of 21 tasks
georgemccabe opened this issue Jun 17, 2021 · 0 comments · Fixed by #961
Closed
20 of 21 tasks

Update GenVxMask wrapper to require setting -type #960

georgemccabe opened this issue Jun 17, 2021 · 0 comments · Fixed by #961
Assignees
Labels
component: python wrapper METplus: Configuration priority: blocker Blocker reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jun 17, 2021

After PR dtcenter/MET#1816, GenVxMask use cases fail because -type was previously optional.

Describe the Enhancement

Update logic to either require that type be set or default to the previous setting which is -type poly.

Time Estimate

<1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added this to the METplus-4.0.1 Bugfix milestone Jun 17, 2021
@georgemccabe georgemccabe self-assigned this Jun 17, 2021
@georgemccabe georgemccabe linked a pull request Jun 17, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper METplus: Configuration priority: blocker Blocker reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants