Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading of updated MCTC and MCTS line types for new HSS statistic. #54

Closed
7 of 21 tasks
TaraJensen opened this issue May 26, 2021 · 4 comments
Closed
7 of 21 tasks
Assignees
Labels
component: load Tasks related to the database loading priority: high High Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/CPC NOAA Climate Prediction Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@TaraJensen
Copy link

TaraJensen commented May 26, 2021

Describe the Enhancement

Heidke Skill Score is being updated to accommodate CPC needs. The MCTS line type in MET version 10.1.0 will include two new columns, HSS_EC and EC_VALUE. The EC_VALUE column will also be added to the MCTC line type to avoid making the EC_VALUE a new required configuration option for plotting.

MET issue to generate new statistics: dtcenter/MET#1749
METviewer issue to plot HSS_EC: dtcenter/METviewer#285

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: Venita
  • Select scientist(s) or no scientist required: no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TaraJensen TaraJensen added type: enhancement Improve something that it is currently doing component: load Tasks related to the database loading requestor: NOAA/CPC NOAA Climate Prediction Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels May 26, 2021
@TaraJensen TaraJensen added this to the METdatadb-1.1 milestone May 26, 2021
@venitahagerty venitahagerty self-assigned this Jun 8, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Add loading of new HSS score to MCTS line type Add loading of updated MCTC and MCTS line types for new HSS statistic. Jun 8, 2021
@JohnHalleyGotway JohnHalleyGotway added the priority: high High Priority label Jun 8, 2021
@TatianaBurek
Copy link
Collaborator

Here is the stat file with MCTC and MCTS data. Please remoce .csv - I had to add it for GitHub
grid_stat_GTG_latlon_060000L_20130827_180000V.stat.csv

@TatianaBurek
Copy link
Collaborator

More data on kiowa
/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta1/feature_1749/MET-feature_1749_hss/test_output/grid_stat

@venitahagerty
Copy link
Contributor

Tatiana let me know that there are 4 new fields in MCTS:

HSS_EC
HSS_EC_BCL
HSS_EC_BCU
EC_VALUE

@venitahagerty
Copy link
Contributor

Made the changes in constants.py and write_stat_sql.py to add the 4 columns to line_data_mcts, and the 1 column to line_data_mctc. Needs the updated mv_mysql.sql from METviewer. Successfully tested with data provided. Pushed to the develop branch.

@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: load Tasks related to the database loading priority: high High Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/CPC NOAA Climate Prediction Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

4 participants