Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test data for VCNT, ECNT, and VL1L2 with newly added columns to the linetype #288

Open
6 of 22 tasks
bikegeek opened this issue Apr 2, 2024 · 0 comments
Open
6 of 22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: code cleanup Code cleanup and maintenance issue component: external dependency External dependency issue component: METdataio component: testing Software testing issue METdataio: General reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Apr 2, 2024

Replace italics below with details for this issue.

Describe the Task

Additional columns were added for ECNT, VCNT, VAL1L2, and VL1L2 by MET which resulted in updating the schema and affected code in METdataio:
#282

Update the tests and data and modify tests if necessary, to use the new data for VCNT, VL1L2, and ECNT. The METdataio METreformat reformatting module currently does not support reformatting the VAL1L2 linetype, but include the updated data for future development.

Time Estimate

1 day

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer Minna Win
  • Select no scientist

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: code cleanup Code cleanup and maintenance issue component: external dependency External dependency issue component: METdataio component: testing Software testing issue METdataio: General reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
None yet
Development

No branches or pull requests

1 participant