Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NDBC locations prior to the MET-11.1.0 release #2511

Closed
15 of 20 tasks
JohnHalleyGotway opened this issue Apr 17, 2023 · 1 comment · Fixed by #2605
Closed
15 of 20 tasks

Update NDBC locations prior to the MET-11.1.0 release #2511

JohnHalleyGotway opened this issue Apr 17, 2023 · 1 comment · Fixed by #2605
Assignees
Labels
MET: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 17, 2023

Describe the Task

The ndbc_stations.xml file defines the "current" locations of the NDBC buoys. Prior to creating the 11.1.0 release, the contents of this file should be updated. While the MET_NDBC_STATIONS environment variable can be set to point to a user-specified version of this file, doing so operationally at EMC is problematic. As such, the MET team should ensure that static file is as up to date as possible.

The longterm preference is to modify this approach to use a version of the NDBC buoy data that is self-describing (i.e. including its lat/lon location). But that version of the NDBC data does not yet exist.

Time Estimate

4 hours?

Sub-Issues

Consider breaking the task down into sub-issues.
None needed

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Configuration priority: high High Priority labels Apr 17, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Apr 17, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Apr 17, 2023
@JohnHalleyGotway JohnHalleyGotway added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label May 18, 2023
@davidalbo
Copy link
Contributor

It seems the content of the files on the web may have changed format. Running the script gives errors for all stations, for example, the wget succeeds, but an error when grepping for a particular string:

wget "https://www.ndbc.noaa.gov/station_page.php?station=32D13"
Command failed  grep "var currentstnid" /d1/personal/dave/MET/MET_development/MET/scripts/python/utility/ndbc_temp_data/stations/station_page.php?station=32D13

which would make this a non-trivial issue to resolve.

@davidalbo davidalbo linked a pull request Jul 10, 2023 that will close this issue
15 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to ✅ Done in MET-11.1.0 Development Jul 10, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants