Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Resume Bayesian Rt calculations #694

Open
vukosim opened this issue Sep 16, 2020 · 5 comments
Open

[Feature] Resume Bayesian Rt calculations #694

vukosim opened this issue Sep 16, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@vukosim
Copy link
Member

vukosim commented Sep 16, 2020

Could we just resume those Rt calculations for the Bayesian model @heerden

@vhschalk
Copy link
Collaborator

There is an open issue on the notebook automation action recipe, thus the action is failing. Will check up on this daily and manually commit for now.

@vukosim
Copy link
Member Author

vukosim commented Sep 17, 2020

Ahh thanks @heerden

Hope you are well.

@vukosim
Copy link
Member Author

vukosim commented Oct 21, 2020

@heerden Quick question, we are no longer getting calculations for GP province in the main file. Is there are a reason for this?

@vhschalk
Copy link
Collaborator

@vukosim In the case of GP data, in the highest_density_interval functions, this sequence becomes zero: best = (highs - lows).argmin(). There is a try-except block to prevent errors like this and will ignore provinces with this error. This means that the confidence interval could not be calculated for GP. I explicitly removed the confidence interval from the SA data, that Rt for could at least be logged on the country level.

See my comments at line 154 here. Note that all the calculation has been moved to pure Python script, since the Notebook recipe (mentioned on 16 Sep), still does not work.

I cannot find a way to debug the model further, to always return a confidence interval.

We can however make to call to still just show the GP results again, without the confidence interval?

@vukosim
Copy link
Member Author

vukosim commented Oct 26, 2020

Thanks. I will also investigate. And get back. THanks @heerden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants