Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Module to meet HQRM Guidelines #12

Open
PlagueHO opened this issue Dec 10, 2017 · 8 comments
Open

Update Module to meet HQRM Guidelines #12

PlagueHO opened this issue Dec 10, 2017 · 8 comments
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@PlagueHO
Copy link
Member

This module needs to be updated to meet HQRM guidelines.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 3, 2018
@johlju
Copy link
Member

johlju commented May 3, 2018

@PlagueHO would this resource it better in ComputerManagementDsc instead of making this resource module HQRM? 🤔

@PlagueHO
Copy link
Member Author

PlagueHO commented May 3, 2018

That is a really good question. It would be good to try and amalgamate some of these little single purpose resources. I'm all for it. What does the PS team think?

@johlju
Copy link
Member

johlju commented May 4, 2018 •
edited
Loading

The only negative I can see is that a user need to use a resource module with more code than maybe they would like. At the same time it is more work having resource spread out in several resource modules when there are no seemingly good reason for them to be the only resource in a resource module.
I have asked the team for their thoughts.

I label this as need investigation, so that I can track it easier on the Waffle board. This does not stop this issue from being worked on.

@johlju johlju added the needs investigation The issue needs to be investigated by the maintainers or/and the community. label May 4, 2018
This was referenced May 4, 2018
Open
Open
@johlju
Copy link
Member

johlju commented May 10, 2018

@PlagueHO The PS DSC Team is on-board with moving this (only got positive votes for moving). I opened an issue here PowerShell/DscResources#374 to get community feedback,

@johlju johlju removed the needs investigation The issue needs to be investigated by the maintainers or/and the community. label May 10, 2018
@PlagueHO
Copy link
Member Author

Awesome! I can fix some of the issues while I'm at it. 😁

@johlju
Copy link
Member

johlju commented May 11, 2018

@PlagueHO Great! 😃 Any issues not resolved we need to make sure we migrate.

@PlagueHO
Copy link
Member Author

In progress now as I migrate this.

@PlagueHO
Copy link
Member Author

This has been fixed over in the new PendingReboot in ComputerManagementDsc. @gaelcolas - can you close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @PlagueHO