Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Module Name to StorageDsc #129

Closed
PlagueHO opened this issue Dec 8, 2017 · 12 comments
Closed

Convert Module Name to StorageDsc #129

PlagueHO opened this issue Dec 8, 2017 · 12 comments
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Milestone

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md

@PlagueHO PlagueHO added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 8, 2017
@PlagueHO PlagueHO added this to the StorageDsc milestone Dec 8, 2017
@timhaintz
Copy link
Contributor

@PlagueHO I noticed the help wanted badge. Yell out if you want to send some things my way. Happy to help as long as you don't mind guiding the way again. :)

@johlju
Copy link
Member

johlju commented Jan 13, 2018

@timhaintz it would be awesome if you want to help out, we will guide you if you need help, just tag us and let us know what you need help with. Also, on any issue, just say that you want to work on it, or that you are working on it, and @PlagueHO will change the label from 'help wanted' to 'in progress' and we will await your PR. 😄

@PlagueHO
Copy link
Member Author

Absolutely @timhaintz - the more the help the better and we're definitely keen to have more people like yourself contributing! So just pop a note in the issue if you want to work on it - all help is gratefully accepted! 😁 The more people contributing changes to these repos enables me to focus on the review (freeing up @johlju - who practically reviews every one of my changes on his own).

If you want more detail etc on a change feel free to pop a message in the issue and I'll provide some greater depth and context. In the case of this issue, we're starting to move all the DSC Resource Kit resources out of "x" (experimental) and using a new naming convention (see the link at the top).

The process for this is as per @johlju's message here (SqlServerDsc was the first repo to undergo this transformation): dsccommunity/SqlServerDsc#902 (comment)

The good thing about this particular change is that it is mostly just renaming files and doing global search/replaces on the names of the resources/modules. But you will want to look at @johlju's instructions carefully as you need to rename your repo after making all the changes and making sure all tests continue to pass. Once complete I can then merge it and get @kwirkykat to rename this repo. We'd then need to update the Wiki as well.

I'm currently performing this process on another repo (dsccommunity/ActiveDirectoryCSDsc#41) so you could look at the process there.

I hope that clarifies the process on this one!

@timhaintz
Copy link
Contributor

Great, thanks @PlagueHO and @johlju will go through the links and try and get up to speed so I can help out a bit more.
Cheers. :D

@timhaintz
Copy link
Contributor

@PlagueHO @johlju sign me up. Will be a great learning experience. I have forked the repo and will start working through it from tonight. Thanks again. Cheers, Tim.

@timhaintz
Copy link
Contributor

@PlagueHO and @johlju I have forked the repo and made the changes. (https://github.com/timhaintz/xStorage) How do I get the tests to run from my repo? I don't want to make a pull request if my tests are failing. I can't run the test to check though.....
Thanks.

@johlju
Copy link
Member

johlju commented Jan 24, 2018

Create a account on AppVeyor, once logged in add a project and choose the fork on GitHub. When the fork is shown in AppVeyor project list then each time you push to your fork AppVeyor will see that and start running the tests. You can see the tests running in the AppVeyor console as well.

For unit test you can run them locally on your dev machine if you like since they should be non-destructive (might be faster running them locally for testing purposes).

If you are working on this issue renamin the repo, then you need to rename your fork, and after that add that as a project in AppVeyor.

@timhaintz
Copy link
Contributor

Thanks @johlju will work on it again tonight.

@timhaintz
Copy link
Contributor

@PlagueHO @johlju #142 created. Please let me know what I have missed or any updates that are required. Thanks, Tim.

@johlju
Copy link
Member

johlju commented Jan 25, 2018

Awesome work! I leave the review part to @PlagueHO. @PlagueHO let me know if you need any help reviewing.

@PlagueHO
Copy link
Member Author

All done now! Thanks @johlju and @timhaintz ! Great stuff!

@joeyaiello joeyaiello removed the help wanted The issue is up for grabs for anyone in the community. label Jan 31, 2018
@timhaintz
Copy link
Contributor

Thanks for all your help @PlagueHO and @johlju . Has been great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants