From c519b3391115710109806ae20556ed3a66475b89 Mon Sep 17 00:00:00 2001 From: Johan Ljunggren Date: Tue, 11 Aug 2020 13:25:26 +0200 Subject: [PATCH] SqlSetup: Update comment-based help in example --- CHANGELOG.md | 17 +++++++++++------ ...lNamedInstanceInFailoverClusterFirstNode.ps1 | 3 --- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bbcbe6902..38598a394 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,15 +5,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -### Added - -- SqlDatabaseObjectPermission - - New integration tests to verify scenarios when passing a single permission. - ### Changed - SqlServerDsc - - Minor document changes in the file `build.yml`. + - Document changes in the file `build.yml`. + - The regular expression for `major-version-bump-message` in the file + `GitVersion.yml` was changed to only raise major version when the + commit message contain the phrase `breaking change`, or when it contain + the word `breaking` or `major`. - SqlSetup - Duplicate function Get-SqlMajorVersion was removed and instead the helper function `Get-FilePathMajorVersion` from the helper module @@ -35,6 +34,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 _DscResource.Common_. - SqlDatabaseObjectPermission - Fixed method invocation failed because of missing `Where()` method ([issue #1600](https://github.com/PowerShell/SqlServerDsc/issues/1600)). + - Added new integration tests to verify scenarios when passing a single permission. +- SqlSetup + - The example `4-InstallNamedInstanceInFailoverClusterFirstNode.ps1` was + updated to no longer reference the issue #405 and issue #444 in the + comment-based help. The issues was fixed a while back and _SqlSetup_ + now supports the built-in parameter `PsDscRunAsCredential` ([issue #975](https://github.com/PowerShell/SqlServerDsc/issues/975)). ## [14.2.0] - 2020-07-23 diff --git a/source/Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 b/source/Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 index 3d00b0a58..f4664b517 100644 --- a/source/Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 +++ b/source/Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 @@ -22,9 +22,6 @@ The media will be copied locally, using impersonation with the credentials provided in SourceCredential, so that the impersonated credentials in SetupCredential can access the media locally. - Setup cannot be run using PsDscRunAsCredential at this time (see issue #405 and issue #444). That - also means that at this time PsDscRunAsCredential can not be used to access media on the UNC share. - There is currently a bug that prevents the resource to logon to the instance if the current node is not the active node. This is because the resource tries to logon using the SYSTEM account instead of the credentials in SetupCredential, and the resource does not currently support the built-in PsDscRunAsCredential either (see