Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: SqlDatabaseRestore #954

Open
arcotek-ltd opened this issue Dec 16, 2017 · 6 comments
Open

New resource: SqlDatabaseRestore #954

arcotek-ltd opened this issue Dec 16, 2017 · 6 comments
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. resource proposal The issue is proposing a new resource in the resource module.

Comments

@arcotek-ltd
Copy link

I've written a resource for restoring databases that can be found here: https://github.com/arcotek-ltd/xSQLDbRestore.

I doubt anyone else wants it and I don't have time to learn how to do all the pester testing right now, so there is little point me raising a PR. (Not that I don't want to learn), but if anyone else thinks it might be a nice addition, please feel free to fix my poor coding (scripting) and add it to the main resource.

HTH.
@arcotek-ltd arcotek-ltd reopened this Dec 16, 2017
@arcotek-ltd
Copy link
Author

If it's closed nobody will see it.

@johlju
Copy link
Member

johlju commented Dec 17, 2017

@arcotek-ltd you could PR in what you have (and sign the CLA) and then I can just tag the PR as abandoned and anyone else can continue your work. Then you get some credit for your work at least. :)
If you don't want to do that, then if someone is gonna take your code and use it then you should add a license to your repo. I suggest a MIT license as that is what this repo is using if your goal is to have your code in this repo.

This is will solve half of issue #532.

@johlju johlju added external The issue cannot be resolved within the DSC Resource Kit. enhancement The issue is an enhancement request. resource proposal The issue is proposing a new resource in the resource module. labels Dec 17, 2017
@johlju johlju removed the external The issue cannot be resolved within the DSC Resource Kit. label May 2, 2018
@johlju johlju added the help wanted The issue is up for grabs for anyone in the community. label May 16, 2018
@stefanDeveloper
Copy link

Any news about restoring a database? It seems that @arcotek-ltd never opened a PR.
Currently, I'm trying to do the same. If this is still unresolved, I'd take over and create PR for it.

@johlju
Copy link
Member

johlju commented Apr 20, 2022

Yes, please. Happy to review a PR for this.

@stefanDeveloper
Copy link

I will create a new resource called SqlDatabaseRestore. Is the naming alright, or should it be placed/named differently?

@johlju
Copy link
Member

johlju commented Apr 28, 2022

The name sounds perfect! The PR title was wrong (name from the module was named xSqlServer), changed now.

@johlju johlju changed the title New resource: xSqlDbRestore New resource: SqlDatabaseRestore Apr 28, 2022
@johlju johlju mentioned this issue May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. resource proposal The issue is proposing a new resource in the resource module.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @stefanDeveloper