Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlRS: Should rename the integration tests configuration name #1880

Closed
johlju opened this issue Mar 25, 2023 · 0 comments · Fixed by #1887
Closed

SqlRS: Should rename the integration tests configuration name #1880

johlju opened this issue Mar 25, 2023 · 0 comments · Fixed by #1887
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Mar 25, 2023

This configuration name wrongly suggest that SqlRS installs the reporting services when it actually configures (or initializes) the Reporting Services. Suggest renaming this configuration (for all SqlRS tests) to better name.

https://github.com/dsccommunity/SqlServerDsc/blob/1e07bc46ecc3efb9f5b7594a2d1cbee5b4899ea6/tests/Integration/DSC_SqlRS.config.ps1#LL162C15-L162C56
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 25, 2023
@johlju johlju mentioned this issue Mar 26, 2023
Merged
9 tasks
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Some maintenance resolving issues johlju/SqlServerDsc
1 participant
@johlju