diff --git a/CHANGELOG.md b/CHANGELOG.md index c83b93d89..d33bdae5c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,8 +5,12 @@ - Changes to SqlAlias - Fixed issue where exception was thrown if reg keys did not exist ([issue #949](https://github.com/PowerShell/SqlServerDsc/issues/949)). +- Changes to SqlDatabase + - Fix minor Script Analyzer warning. - Changes to SqlServerNetwork - Added sysadmin account parameter usage to the examples. +- Changes to SqlServerReplication + - Fix Script Analyzer warning ([issue #263](https://github.com/PowerShell/SqlServerDsc/issues/263)). - Changes to SqlServiceAccount - Default services are now properly detected ([issue #930](https://github.com/PowerShell/SqlServerDsc/issues/930)). diff --git a/DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1 b/DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1 index 5e48b7448..ae2333b79 100644 --- a/DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1 +++ b/DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1 @@ -146,7 +146,6 @@ function Set-TargetResource if ($sqlServerObject) { - if ($Ensure -eq 'Present') { if (-not $PSBoundParameters.ContainsKey('Collation')) diff --git a/DSCResources/MSFT_SqlServerReplication/MSFT_SqlServerReplication.psm1 b/DSCResources/MSFT_SqlServerReplication/MSFT_SqlServerReplication.psm1 index a7f09403c..0d731917f 100644 --- a/DSCResources/MSFT_SqlServerReplication/MSFT_SqlServerReplication.psm1 +++ b/DSCResources/MSFT_SqlServerReplication/MSFT_SqlServerReplication.psm1 @@ -447,7 +447,7 @@ function Register-DistributorPublisher function Get-ConnectionInfoAssembly { [CmdletBinding()] - [OutputType([System.Object])] + [OutputType([System.Reflection.Assembly])] param( [Parameter(Mandatory = $true)] [System.String] @@ -463,7 +463,7 @@ function Get-ConnectionInfoAssembly function Get-RmoAssembly { [CmdletBinding()] - [OutputType([System.Object])] + [OutputType([System.Reflection.Assembly])] param( [Parameter(Mandatory = $true)] [System.String]