BREAKING CHANGE: ClusterDisk: Disk number changes between reboots

[johlju]

The resource xClusterDisk should change to use the same logic as xDisk and xWaitForDisk over at xStorage.
See issue dsccommunity/StorageDsc#81 and the change will be merged in dsccommunity/StorageDsc#87.

PR description from dsccommunity/StorageDsc#87:

Removes DiskNumber parameter and replaces with DiskId and DiskIdType. The reason why this was done is because DiskNumber is not a reliable method of identifying disks (it can change between reboots as has been shown). This change will allow support for both DiskNumber and Disk Unique Id to identify disks.

I think this means that the current proposed change in PR #26 should not be merged since that PR is proposing to change to identify disk using the Guid property.

UniqueId is the same for both the cmdlet Get-Disk to get the disks (used by xStorage\xDisk resource) and using Get-CimInstance to get the cluster disks (used by xClusterDisk resource).

PS > Get-Disk | Select Number,UniqueId

Number UniqueId
------ --------
     0 6000C29FB215833D878679F2A872C08C
     4 60003FF44DC75ADCA9D3B0EAAE6D327C
     1 60003FF44DC75ADCB404B1E06EA33A2A
     3 60003FF44DC75ADC9583AC6C75E03D96
     2 60003FF44DC75ADCB300A3B38C2273A4
     5 60003FF44DC75ADC9B337A5F69B4C5DF

PS > Get-CimInstance -ClassName MSCluster_Disk -Namespace 'Root\MSCluster' | Select Number,UniqueId

Number UniqueId
------ --------
     3 60003FF44DC75ADC9583AC6C75E03D96
     5 60003FF44DC75ADC9B337A5F69B4C5DF
     4 60003FF44DC75ADCA9D3B0EAAE6D327C
     2 60003FF44DC75ADCB300A3B38C2273A4
     1 60003FF44DC75ADCB404B1E06EA33A2A