Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit tests for private functions #403

Closed
johlju opened this issue Dec 28, 2022 · 0 comments · Fixed by #405
Closed

Missing unit tests for private functions #403

johlju opened this issue Dec 28, 2022 · 0 comments · Fixed by #405
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub in progress The issue is being actively worked on by someone. tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Dec 28, 2022 •
edited
Loading

There are several private functions that never got there corresponding unit test merged. They were missed during review of PR #395.

The unit tests already exists here: https://github.com/dsccommunity/SqlServerDsc/tree/main/tests/Unit/Private

The unit tests need to be modified to be able to be run by Pester 4 since the pipeline here does not yet use Pester 5.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Dec 28, 2022
This was referenced Jan 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub in progress The issue is being actively worked on by someone. tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
1 participant
@johlju