Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteDesktopAdmin: New resource proposal #224

Closed
X-Guardian opened this issue Jun 23, 2019 · 2 comments · Fixed by #227
Closed

RemoteDesktopAdmin: New resource proposal #224

X-Guardian opened this issue Jun 23, 2019 · 2 comments · Fixed by #227
Labels
enhancement The issue is an enhancement request. resource proposal The issue is proposing a new resource in the resource module.

Comments

@X-Guardian
Copy link
Contributor

Description

There is currently a separate DSC module xRemoteDesktopAdmin which contains a single resource for configuring 'Remote Desktop for Administration' on a Windows server, along with the RDP Authentication security. The resource code for this hasn't been touched for 4 years and has outstanding bugs, and also needs making SingleInstance. I started to submit PRs to bring the module up to HQRM standards and fix the bugs, but then though that perhaps rather than having a separate module for one simple resource, it would be better integrated into the ComputerManagementDsc module.
I've already re-written the resource to HQRM standards along with Pester tests.

Proposed properties

[ClassVersion("1.0.0.0"), FriendlyName("RemoteDesktopAdmin")]
class MSFT_RemoteDesktopAdmin : OMI_BaseResource
{
    [Key, Description("Specifies the resource is a single instance, the value must be 'Yes'"), ValueMap{"Yes"}, Values{"Yes"}] String IsSingleInstance;
    [Required, Description("Determines whether or not the computer should accept remote desktop connections.  Present sets the value to Enabled and Absent sets the value to Disabled."), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;
    [Write, Description("User Authentication.  Setting this value to Secure configures the machine to require Network Level Authentication (NLA)."), ValueMap{"Secure","NonSecure"}, Values{"Secure","NonSecure"}] String UserAuthentication;
};

Special considerations or limitations

None

@PlagueHO PlagueHO added enhancement The issue is an enhancement request. resource proposal The issue is proposing a new resource in the resource module. labels Jun 24, 2019
@PlagueHO
Copy link
Member

Hi @X-Guardian - sounds like a good idea. I'm in agreement that bringing it into this module makes sense - especially if you've done the HQRM work already.

@X-Guardian
Copy link
Contributor Author

Cheers @PlagueHO, I'll raise a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. resource proposal The issue is proposing a new resource in the resource module.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants