From 3aea92671dd0d5ad102715e54d78d165d772099f Mon Sep 17 00:00:00 2001 From: Johan Ljunggren Date: Mon, 7 Nov 2022 05:55:26 +0100 Subject: [PATCH] ComputerManagementDsc: Remove resource named from module manifest in `source` (#397) * ComputerManagementDsc: Remove resource named from module manifest in `source` * Fix typo in CHANGELOG.md * Fix review comment at r1 * Fix changelog --- CHANGELOG.md | 7 +++++++ source/ComputerManagementDsc.psd1 | 19 +------------------ 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f4b0414..40472801 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Support Options Parameter for domain join - Fixes [Issue #234](https://github.com/dsccommunity/ComputerManagementDsc/issues/234). - When joining a computer to a domain, existing AD computer objects will be deleted - Fixes [Issue #55](https://github.com/dsccommunity/ComputerManagementDsc/issues/55), [Issue #58](https://github.com/dsccommunity/ComputerManagementDsc/issues/58). +### Changed + +- ComputerManagementDsc + - The resource names were removed from the property `DscResourcesToExport` + in the module manifest in the source folder as the built module is + automatically updated with this information by the pipeline - Fixes [Issue #396](https://github.com/dsccommunity/ComputerManagementDsc/issues/396). + ## [8.5.0] - 2021-09-13 ### Added diff --git a/source/ComputerManagementDsc.psd1 b/source/ComputerManagementDsc.psd1 index 81ab0be9..2dda04f6 100644 --- a/source/ComputerManagementDsc.psd1 +++ b/source/ComputerManagementDsc.psd1 @@ -36,24 +36,7 @@ AliasesToExport = @() # DSC resources to export from this module - DscResourcesToExport = @( - 'Computer' - 'OfflineDomainJoin' - 'PendingReboot' - 'PowerPlan' - 'PowerShellExecutionPolicy' - 'RemoteDesktopAdmin' - 'ScheduledTask' - 'SmbServerConfiguration' - 'SmbShare' - 'SystemLocale' - 'TimeZone' - 'VirtualMemory' - 'WindowsEventLog' - 'WindowsCapability' - 'IEEnhancedSecurityConfiguration' - 'UserAccountControl' - ) + DscResourcesToExport = @() # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell. PrivateData = @{