-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlatyPS to required modules #715
base: main
Are you sure you want to change the base?
Conversation
@johlju Sorry - not sure why this is failing? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Very strange - not sure either, kicked off the pipeline again. It got GitVersion 6 event if it says it should install v5. 🤔 |
Seems to work now, I can't see any errors in the build phase. Seems to work with adding PlatyPS. This should also update the conceptual help so we should no longer need to have the individual .help.txt for the resources. They are generated automatically in the top |
But there seems to a problem with this module, maybe because there is a docs folder in the helper module the auto-doc creates this file?
Solution 1. Moving the docs folder to Solution 2. If the all common command can be made public we can just add a Solution 3. Move the helper module to it's own repository similar to how DscResource.Common is seperated. Then add it the same way as DscResource.Common is used. Moving relevant commands to DscResource.Common is also an option. 🤔 Guessing solution 1 is easiest - at least moving away the 'docs' folder so it is not part of the generated module. 🙂 |
@johlju OK - probably not something I can spend any more time on, sorry (doing this on company time). I'll leave this here in case someone else can pick it up! |
Pull Request (PR) description
As discussed in #714, adding PlatyPS to required modules in an attempt to resolve build errors
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is