Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADDomain: Get-TargetResource is not returning actual value for some properties #486

Closed
johlju opened this issue Aug 18, 2019 · 1 comment · Fixed by #566
Closed

ADDomain: Get-TargetResource is not returning actual value for some properties #486

johlju opened this issue Aug 18, 2019 · 1 comment · Fixed by #566
Assignees
@X-Guardian
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Aug 18, 2019

The function Get-TargetResource of the resource ADDomain is not returning the actual value for some of the properties in the schema.mof.

Missing values for the properties:

  • DnsDelegationCredential
  • DatabasePath
  • LogPath
  • SysvolPath

A way of determine the actual value should be found a make sure to return the correct value in the hashtable when the domain exist.
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Aug 18, 2019
@johlju
Copy link
Member Author

johlju commented Aug 25, 2019

Three of the values are return in the ADDomainController resource, so they could be fetch similarly

https://github.com/PowerShell/ActiveDirectoryDsc/blob/0b8790a09564e4c24c0ea55684def005f144460c/DSCResources/MSFT_ADDomainController/MSFT_ADDomainController.psm1#L133-L135

@X-Guardian X-Guardian mentioned this issue Feb 11, 2020
Merged
9 tasks
@X-Guardian X-Guardian added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 11, 2020
@X-Guardian X-Guardian self-assigned this Feb 11, 2020
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@X-Guardian X-Guardian

Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
2 participants
@johlju @X-Guardian