Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaitForADDomain: Use helper function Get-ADDirectoryContext #432

Closed
johlju opened this issue Jul 13, 2019 · 0 comments · Fixed by #455
Closed

WaitForADDomain: Use helper function Get-ADDirectoryContext #432

johlju opened this issue Jul 13, 2019 · 0 comments · Fixed by #455
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 13, 2019

We should replace the below code with the helper function Get-ADDirectoryContext to simplify the code and not duplicating code.

https://github.com/PowerShell/xActiveDirectory/blob/dd53b43a46a6e7ddd101a0b7f393af0d377b100e/DSCResources/MSFT_xWaitForADDomain/MSFT_xWaitForADDomain.psm1#L215-L222
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 13, 2019
@johlju johlju changed the title xWaitForADDomain: Use helper function Get-ADDirectoryContext WaitForADDomain: Use helper function Get-ADDirectoryContext Jul 28, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 30, 2019
@johlju johlju mentioned this issue Aug 2, 2019
Merged
9 tasks
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
1 participant
@johlju