From 3a4b75feb7dd13014fb2cd7033f438fc7a808731 Mon Sep 17 00:00:00 2001
From: Johan Ljunggren <johlju@users.noreply.github.com>
Date: Sat, 3 Aug 2019 11:44:02 +0200
Subject: [PATCH] Changes to ActiveDirectoryDsc (#459)

- Changes to ActiveDirectoryDsc
  - Integration tests are now correctly evaluates the value from `Test-DscConfiguration` (issue #434).
---
 CHANGELOG.md                                       |  2 ++
 .../MSFT_ADComputer.Integration.Tests.ps1          | 14 +++++++-------
 .../MSFT_ADDomainTrust.Integration.Tests.ps1       | 12 ++++++------
 .../Integration/MSFT_ADUser.Integration.Tests.ps1  |  4 ++--
 4 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 68fcffa2e..6dab6cf23 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -57,6 +57,8 @@
     Azure Automation ([issue #416](https://github.com/PowerShell/ActiveDirectoryDsc/issues/416)).
   - Fix examples that had duplicate guid that would have prevented them
     to be published.
+  - Integration tests are now correctly evaluates the value from `Test-DscConfiguration`
+    ([issue #434](https://github.com/PowerShell/ActiveDirectoryDsc/issues/434)).
 - Changes to ADManagedServiceAccount
   - Added a requirement to README stating "Group Managed Service Accounts
     need at least one Windows Server 2012 Domain Controller"
diff --git a/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1
index e8825cf58..8343b038d 100644
--- a/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1
+++ b/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1
@@ -93,7 +93,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -140,7 +140,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -187,7 +187,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -234,7 +234,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -285,7 +285,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -349,7 +349,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -380,7 +380,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }
diff --git a/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1
index ea56fc1a8..81ed43ae3 100644
--- a/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1
+++ b/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1
@@ -81,7 +81,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -132,7 +132,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -183,7 +183,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -234,7 +234,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -285,7 +285,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -336,7 +336,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }
diff --git a/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1
index 60201247e..5ce86bc1f 100644
--- a/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1
+++ b/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1
@@ -80,7 +80,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -130,7 +130,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }