Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang on StartTls if connected to a server that doesn't support STARTTLS #103

Open
Kim-SSi opened this issue Nov 21, 2019 · 1 comment
Open

Comments

@Kim-SSi
Copy link
Contributor

Kim-SSi commented Nov 21, 2019

When connecting to an OpenLDAP instance running without STARTTLS and trying to do a StartTls the process hangs at:

To bypass this I have altered the line to:

Monitor.Wait(_messages, 5000);

This might cause other unforeseen issues. Ideally this should be set to the timeout value instead of a hard coded value. Both of these concerns is why I have not created a pull request.

I am checking for STARTTLS support via the RootDSE supportedExtension but unfortunately not all servers expose the capability when it is supported. And some users want to use that configuration with their servers.

@Kim-SSi
Copy link
Contributor Author

Kim-SSi commented Nov 22, 2019

Should the other Monitor.Wait without timeout be changed to include a timeout so that it can't possibly hang?


There already is a timeout value in the Message class.

Monitor.Wait(_replies, _mslimit);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants