-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTP Status 429 - Too Many Requests #20
Comments
👍 |
👍 Yeah, 429 is much better response. Also we need some rate limit indicating headers like these. http://stackoverflow.com/a/16022625/228589 |
👍 |
How is this? |
It's pretty easy to use 429 if you want to: https://github.com/dryruby/rack-throttle/blob/v0.5.0/lib/rack/throttle/limiter.rb#L22. It's also documented in the README. |
We're talking about the default status |
Oops, sorry, read too quickly. 👍 |
This still has the potential to break lots of peoples setups if just done. I think it may be good to have this be listed as a deprecation for a period before deploying. |
@FreekingDean Absolutely. Good point. |
When throttling, it might be more accurate to return the following status code:
This is apparently intended for use with rate limiting schemes.
I realise that defaulting to this error code would be a backwards incompatible, but I think this should be documented. I can provide a PR updating the README.
Related: #5 (which changed the default status code, rather than simply documenting it)
The text was updated successfully, but these errors were encountered: